[FFmpeg-devel] [RFC][PATCH] configure: libfreetype check
eclipse7 at gmx.net
Sun Dec 8 18:28:01 CET 2013
On 2013-12-07 23:14 +0100, Alexander Strasser wrote:
> On 2013-12-07 11:41 +0100, Alexander Strasser wrote:
> > On 2013-12-07 01:12 +0100, Alexander Strasser wrote:
> > > On 2013-12-06 23:25 +0100, Clément Bœsch wrote:
> > > > On Fri, Dec 06, 2013 at 10:55:04PM +0100, Alexander Strasser wrote:
> [all patches skipped]
> > > >
> > > > This approach looks the saner.
> > > >
> > > > Also note that you need to remove one #include in the drawtext filter to
> > > > make the compilation works.
> > >
> > > Yeah, I got a notice about that. The inlcude can just be deleted,
> > > I think it was wrong to begin with. But to be sure I will check the
> > > history of that file.
> > Checked it. Was already wrong in the initial commit.
> > So if I hear no more comments, I will go with variant 3 + removal
> > of the wrong #include in vf_drawtext. I am planning to commit tomorrow
> > evening CET at latest. Maybe earlier; I do not like to leave build
> > problems like this open for too long, it hinders all the builders that
> > enable libfreetype and have a version with the headers moved.
> > Variant 3 was also favored by one person on IRC.
> I somehow managed to lose the error exit (=> die) when implementing
> the third approach. Added that now and also included the deletion of
> the freetype/... header in vf_drawtext.
> New patch attached.
Pushed with a bunch of further fixes.
Thanks to ubitux and Nothing4You for reviewing and testing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the ffmpeg-devel