[FFmpeg-devel] [PATCH] windres: Track dependencies

James Almer jamrial at gmail.com
Sun Dec 8 19:57:36 CET 2013


On 07/12/13 4:37 PM, Michael Niedermayer wrote:
> On Fri, Dec 06, 2013 at 11:45:05PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
> 
> applied
> 
> btw, do we have a maintainer for the windres stuff ?
> if not someone should add himself to MAINTAINERs
> 
> thanks

I'm the mantainer, yes. I'll send a patch later.

I'm trying to see how to fix the current fate failures on your and Hendrik's 
systems. I think i found out what is causing them, but for some reason i can't 
reproduce the issue on my end.

Can you two try this patch and see if it solves the failures?
Thanks.
-------------- next part --------------
diff --git a/common.mak b/common.mak
index d4d5fcb..48f5c21 100644
--- a/common.mak
+++ b/common.mak
@@ -61,7 +61,7 @@ COMPILE_HOSTC = $(call COMPILE,HOSTCC)
 	$(COMPILE_HOSTC)
 
 %.o: %.rc
-	$(WINDRES) $(IFLAGS) --preprocessor "$(DEPCC) -E -xc-header -DRC_INVOKED $(CC_DEPFLAGS)" -o $@ $<
+	$(WINDRES) $(IFLAGS) --preprocessor "$(subst @,,$(DEPCC)) -E -xc-header -DRC_INVOKED $(CC_DEPFLAGS)" -o $@ $<
 
 %.i: %.c
 	$(CC) $(CCFLAGS) $(CC_E) $<


More information about the ffmpeg-devel mailing list