[FFmpeg-devel] [PATCH] avcodec/libvpx: set CODEC_CAP_EXPERIMENTAL correctly instead of testing at codec open time
jzern at google.com
Tue Dec 10 06:02:33 CET 2013
On Mon, Dec 9, 2013 at 7:13 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Dec 09, 2013 at 06:35:17PM -0300, James Almer wrote:
>> On 09/12/13 6:08 PM, James Zern wrote:
>> > On Sun, Dec 8, 2013 at 2:14 PM, James Almer <jamrial at gmail.com> wrote:
>> >> On 08/12/13 10:19 AM, Michael Niedermayer wrote:
>> >>> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
>> >>> ---
>> >>> libavcodec/libvpx.c | 13 ++++---------
>> >>> libavcodec/libvpx.h | 2 +-
>> >>> libavcodec/libvpxdec.c | 4 +---
>> >>> libavcodec/libvpxenc.c | 4 +---
>> >>> 4 files changed, 7 insertions(+), 16 deletions(-)
>> >> Maybe we should leave a log message about libvpx < 1.3.0 as an
>> >> AV_LOG_WARNING line.
>> >> The idea is that the warning will show up after running ffmpeg with
>> >> -strict -2, so the user knows that what's experimental is VP9 encoding
>> >> with their libvpx version and not ffmpeg's wrapper, and that they
>> >> should consider updating it.
>> > This now happens at registration time, so the log would be issued even
>> > if you weren't using vp9.
>> The log can for example be in vp9_init() (Both encoder and decoder). That
>> way it will only trigger for VP9 and libvpx < 1.3.0.
>> It will however need an extra version check there.
> i can add such check if wanted ?
Your preference. The bitstream was stable prior to 1.3.0, but after a
bit this should all be in configure I guess with a minimum of 1.3.0
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> When the tyrant has disposed of foreign enemies by conquest or treaty, and
> there is nothing more to fear from them, then he is always stirring up
> some war or other, in order that the people may require a leader. -- Plato
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel