[FFmpeg-devel] [PATCH] libavcodec/dvbsub: fix for Display Definition Segment

[Michael Niedermayer]

On Fri, Dec 13, 2013 at 02:55:22PM +0000, Kieran Kunhya wrote:
> On 13 December 2013 13:29, Pierre Yves MORDRET
> <pierre-yves.mordret at st.com> wrote:
> > Given ETSI EN 300 743 V1.3.1 (2006-11), 7.2.1 Display definition segment
> > display window parameters are given in this order XMin, XMax, YMin, YMax
> > if  display_window_flag is set, but here this is not the case.
> > As a consequence the DVB subtitles are not displayed upon some videos.
> >
> > Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret at st.com>
> > ---
> >  libavcodec/dvbsubdec.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c
> > index 4ce40aa..2e845df 100644
> > --- a/libavcodec/dvbsubdec.c
> > +++ b/libavcodec/dvbsubdec.c
> > @@ -1359,8 +1359,8 @@ static void dvbsub_parse_display_definition_segment(AVCodecContext *avctx,
> >
> >      if (info_byte & 1<<3) { // display_window_flag
> >          display_def->x = bytestream_get_be16(&buf);
> > -        display_def->y = bytestream_get_be16(&buf);
> >          display_def->width  = bytestream_get_be16(&buf) - display_def->x + 1;
> > +        display_def->y = bytestream_get_be16(&buf);
> >          display_def->height = bytestream_get_be16(&buf) - display_def->y + 1;
> >      }
> >  }
> > --
> > 1.7.9.5
> >
> 
> Looks ok

applied

thanks

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131213/da363207/attachment.asc>