[FFmpeg-devel] mjpegenc: wrong chrominance sampling values written to SOF header for YUVJ422P?

Michael Niedermayer michaelni at gmx.at
Sat Dec 14 19:10:22 CET 2013


On Sat, Dec 14, 2013 at 03:43:01PM +0200, Andrey Utkin wrote:
> Not much related, but i'll just post it here.
> Seems one more issue in mjpegenc.c
> line 141:
>     if(avctx->active_thread_type & FF_THREAD_SLICE){
>         put_marker(p, DRI);
>         put_bits(p, 16, 4);  // <===== Section size of 4 bytes is declared
>         put_bits(p, 16, (avctx->width-1)/(8*hsample[0]) + 1);  //
> <==== two bytes written
>         // <===== There should be two more bytes written, AFAIU 0xFFFF
> hardcode may be used.
>     }

Why do you think so ?

ITU T.81 says that the size must be 4 and is followed
by 2 bytes and there is no additional data after that
(id copy & paste the spec but its in tables that get randmized if i
 copy and paste them)


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131214/6ebcde09/attachment.asc>


More information about the ffmpeg-devel mailing list