[FFmpeg-devel] [PATCH 1/2] avfilter/buffersrc: specify pixel format min/max

Stefano Sabatini stefasab at gmail.com
Mon Dec 16 15:35:11 CET 2013


On date Saturday 2013-12-07 16:06:28 +0100, Michael Niedermayer encoded:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavfilter/buffersrc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c
> index 6b6210d..8cdbc5d 100644
> --- a/libavfilter/buffersrc.c
> +++ b/libavfilter/buffersrc.c
> @@ -326,7 +326,7 @@ static const AVOption buffer_options[] = {
>      { "width",         NULL,                     OFFSET(w),                AV_OPT_TYPE_INT,      { .i64 = 0 }, 0, INT_MAX, V },
>      { "video_size",    NULL,                     OFFSET(w),                AV_OPT_TYPE_IMAGE_SIZE,                .flags = V },
>      { "height",        NULL,                     OFFSET(h),                AV_OPT_TYPE_INT,      { .i64 = 0 }, 0, INT_MAX, V },
> -    { "pix_fmt",       NULL,                     OFFSET(pix_fmt),          AV_OPT_TYPE_PIXEL_FMT,                 .flags = V },
> +    { "pix_fmt",       NULL,                     OFFSET(pix_fmt),          AV_OPT_TYPE_PIXEL_FMT,{ .i64 =-1 },-1, AV_PIX_FMT_NB-1, .flags = V },

Is -1 really allowed?

Also AV_PIX_FMT_NB-1 should be probably replaced by INT_MAX. I'm going
to send a few opt patches to fix how we set it.
-- 
FFmpeg = Fascinating and Faithful Mortal Puristic Elected God


More information about the ffmpeg-devel mailing list