[FFmpeg-devel] [PATCH 3/7] lavc/utils: check av_frame_alloc() failure.

Michael Niedermayer michaelni at gmx.at
Sun Dec 29 11:13:33 CET 2013


On Sun, Dec 29, 2013 at 11:11:44AM +0100, Nicolas George wrote:
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  libavcodec/utils.c | 4 ++++
>  1 file changed, 4 insertions(+)

LGTM if the error pathes where tested under valgrind or similar

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131229/a3256925/attachment.asc>


More information about the ffmpeg-devel mailing list