[FFmpeg-devel] [PATCH] libopenjpegenc: add 9-15 bit RGB output

[Michaël Cinquin]

On 1 févr. 2013, at 11:30, Jean First wrote:

> please a a space around >

done


>> + av_log(avctx, AV_LOG_DEBUG, "cinema-mode\n"); 

done


>> + ctx->enc_params.irreversible = 1; + ctx->enc_params.tcp_mct = 1; 
> after a quick look at https://github.com/tmeiczin/OpenDCP/blob/master/libopendcp/codecs/opendcp_encoder_openjpeg.c
> it seemsthat: tcp_mct  =  opj_image->numcomps  ==  3  ?  1  :  0;
>> + ctx->enc_params.tile_size_on = 0; + /* no subsampling*/ + ctx->enc_params.cp_tdx=1; + ctx->enc_params.cp_tdy=1; 

When encoding DCI-compliant j2c, you have 3 channels (XYZ), so I thought we could skip this test or so I thought


> I forgot to ask: Did you use ffmepg to create the mxf aswell ?
> And it would be nice if you could add a "How to create DCP" to http://ffmpeg.org/trac/ffmpeg/wiki .

No, mxf wrapping was done with asdcp-test ; as far as I know, FFmpeg does not make for now mxf that are DCI-compliant

New patch attached

Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libopenjpegenc-make_dci_compliant_j2c-3.patch
Type: application/octet-stream
Size: 4641 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130201/0fb8cdc3/attachment.obj>