[FFmpeg-devel] [PATCH]Fix building with --disable-everything

[Carl Eugen Hoyos]

Paul B Mahol <onemda <at> gmail.com> writes:

> >> That is not explanation why you decided to make such
> >> changes and not some other ones.
> >
> > I did not find any other change that fixes compilation
> > with --disable-everything.
> > (But I don't consider that an explanation for this
> > patch. The relevant reason is that we have a
> > regression in the build system that I would like
> > to fix.)
> 
> But the fix you provided is hack. You just did some changes and
> declare: "hey, this works lets post it on mailing list".

No.

I searched for the undefined symbols and provided them 
with the same logic than the functions that need them.
(But this is of course not an explanation for this 
patch, it is just the default rule for handling such 
build problems.)

> Fact that patch works is not enough to guarantee that 
> it is also correct.

I never claimed that this patch is correct, please 
do not put words in my mouth.

I claimed that the patch fixes ticket #2253 (an important 
regression) and this is what my tests showed, I did not 
try to proof formally.

Carl Eugen