[FFmpeg-devel] [PATCH] libfdk-aacenc: Actually check for upper bounds of cutoff

Derek Buitenhuis derek.buitenhuis at gmail.com
Sat Feb 9 23:04:19 CET 2013

On 2013-02-09 4:47 PM, Michael Niedermayer wrote:
> if libfdk-aacenc needs these explicit checks then sure patch ok
> but please use the correct tool name in the commit message.

That wasn't actually part of the commit message. It's an annotated
note below it.

> besides this, IMHO its libfdk-aacencs job to check such parameters
> its non ideal to hardcode such numbers in user applications

If you wanna try and convince Fraunhofer, you may try.

> also you have a off by 1 error in there somewhere as the commit
> message says talks about 20000 with no warnings while the code looks
> like it would only start having an issue with 20001

Sorry, that was a bad example. It's silent with 20001+ too.

- Derek

More information about the ffmpeg-devel mailing list