[FFmpeg-devel] [PATCH] swscale: Add support for unscaled 8-bit Packed RGB -> Planar RGB

Derek Buitenhuis derek.buitenhuis at gmail.com
Sat Feb 9 23:56:27 CET 2013

On 2013-02-09 5:06 PM, Michael Niedermayer wrote:
> that can be simplified with a
> if(alpha_first)
>     src++;
> outside the loop, i think

You're right. Will do.

> these 2 can be simplified with 2  FFSWAP
> the advantage is smaller code size if the compiler chooses to inline
> packed24togbr24p

I wrote it to match a805cefd8b81e551ab7dfb6a7ae8b5a1512e7893, for consistency.
If this changes, that should change too.

I also notice a mistake I made: 

> +    if (srcFormat == AV_PIX_FMT_GBRP && isPlanarRGB(dstFormat) && isByteRGB(dstFormat))
> +        c->swScale = rgbToPlanarRgbWrapper;

This is the wrong check. srcFormat should NOT be GBRP.

I'll fix and resend after I get my other set of reviews from the Other Place.

- Derek

More information about the ffmpeg-devel mailing list