[FFmpeg-devel] [PATCH 1/2] lavfi/vf_ass: ignore subtitles decoding errors.

Nicolas George nicolas.george at normalesup.org
Wed Feb 13 17:17:14 CET 2013

Le quintidi 25 pluviôse, an CCXXI, Clement Boesch a écrit :
> I'm not sure about removing the got_subtitle check. You might read again
> from the previous decoded sub (if any).

avcodec_decode_subtitle2() calls avcodec_get_subtitle_defaults(), which sets
num_rects to 0 amongst other things.

(And patch 2/2 ensures that a bogus decoder will not return num_rects != 0
without setting got_subtitle to 1.)

Therefore, I believe it is safe.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130213/162e2a28/attachment.asc>

More information about the ffmpeg-devel mailing list