[FFmpeg-devel] [PATCH 1/2] lavfi/vf_ass: ignore subtitles decoding errors.

Nicolas George nicolas.george at normalesup.org
Wed Feb 13 17:34:52 CET 2013

Le quintidi 25 pluviôse, an CCXXI, Clement Boesch a écrit :
> I'd be more comfortable with a:
>   if (ret < 0) {
>       av_log(...)
>   } else {
>       for (i = 0; i < sub->num_rects; i++)
>           ...
>   }

You are the boss for this part of the file; new patch incoming.

> ...because in the decoder, it might makes sense to not cleanup the sub
> content in case of error (certainly simpler). got_subtitle IMO overrules
> anything in sub.

I would consider it a bug of the decoder. But of course, checking it thrice
is better than a segfault (this is not speed-critical).


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130213/f26fa2ba/attachment.asc>

More information about the ffmpeg-devel mailing list