[FFmpeg-devel] [PATCH] lavfi/vf_ass: ignore subtitles decoding errors.

Clément Bœsch ubitux at gmail.com
Thu Feb 14 19:09:26 CET 2013

On Thu, Feb 14, 2013 at 04:39:47PM +0100, Nicolas George wrote:
> Le quintidi 25 pluviôse, an CCXXI, Clement Boesch a écrit :
> > LGTM, thanks.
> Thanks, pushed with the additional reindent.
> Ping for "[2/2] lavc: check return values consistency when decoding
> subtitles".

I thought it wasn't necessary anymore...

> +        av_assert1((ret >= 0) >= !!*got_sub_ptr &&

OK for this

Note: I don't think using av_assert1 instead of av_assert0 is really

> +                   !!*got_sub_ptr >= !!sub->num_rects);

As said in the previous mail, I think it's good to allow the subtitles
decoders to let the AVSubtitle in an incomplete state and prevent anyone
from reading in it using got_sub_ptr. Or said differently, got_sub_ptr=0
and sub->num_rects=3 is valid since got_sub_ptr overrules reading anything
in sub.

Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130214/46ca9ed9/attachment.asc>

More information about the ffmpeg-devel mailing list