[FFmpeg-devel] [PATCH] lavc/flacdec: Add frame CRC calculation

Michael Niedermayer michaelni at gmx.at
Sun Feb 17 01:30:57 CET 2013

On Sat, Feb 16, 2013 at 08:56:18PM -0300, James Almer wrote:
> On 16/02/13 8:45 PM, Michael Niedermayer wrote:
> > On Sat, Feb 16, 2013 at 06:07:49AM -0300, James Almer wrote:
> >> Fixes ticket #2266
> >>
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> > 
> > does this improve or worsen the way damaged files sound ?
> > 
> > (the check is enabled be default if i didnt  misread teh code)
> Like in other decoders, the damaged frame is discarded but the
> decoding is not interrupted.

thats not awnsering my question
my goal here is that the default should be what sounds best, in the
sense of a human listening to A and B and saying "i prefer A"
loud pops, clicks and squeeks would be annoying so would be missing
and repeating the last good audio frame could sound better than

adding support for (non default enabled) crc checking is certainly
ok OTOH ..

but if its on by default theres the question if its what most people
would prefer aka it sounds better ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130217/6cc9b8d3/attachment.asc>

More information about the ffmpeg-devel mailing list