[FFmpeg-devel] [PATCH 2/2] lavc: support subtitles charset conversion.

[Clément Bœsch]

On Sun, Feb 17, 2013 at 12:46:21PM +0100, Nicolas George wrote:
> Le nonidi 29 pluviôse, an CCXXI, Clement Boesch a écrit :
> > On top of the structure:
> > 
> >  "Please use AVOptions (av_opt* / av_set/get*()) to access these fields
> >  from user applications."
> 
> Yes, but a lot of examples and code access the usual fields directly, and
> the rule about not accessing directly the fields is written for each
> publicly useful ffmpeg-only field (see codec_descriptor).
> 

codec_descriptor and pkt_timebase are the only exceptions because they
have specific getters. A lot of fields of the struct are to be accessed
through the av_opt* options (and it's not said explicitely), which is
(now) the case of sub_charenc_mode.

> > Removed the comment. Also added options to access the field.
> 
> Thanks.
> 
> > Was left for later, removed.
> 
> I wondered why it was disabled, in fact. It does not matter much, though.
> 

Because no code was using it at the moment, it was like a TODO

> > I'm glad to hear this :)
> > 
> > I'll push this version soon, along with the other patches (filter changes).
> 
> LGTM at a quick glance.
> 

Thanks

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130217/841e3176/attachment.asc>