[FFmpeg-devel] [PATCH] x86/dsputil: fix compilation when h263 decoder/encoder are disabled.
michaelni at gmx.at
Mon Feb 18 15:37:57 CET 2013
On Mon, Feb 18, 2013 at 02:33:54PM +0000, Paul B Mahol wrote:
> On 2/18/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Feb 18, 2013 at 12:38:02PM +0000, Paul B Mahol wrote:
> >> On 2/18/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Sun, Feb 17, 2013 at 06:20:17PM -0800, Ronald S. Bultje wrote:
> >> >> From: "Ronald S. Bultje" <rsbultje at gmail.com>
> >> >>
> >> >> The symbol "ff_h263_loop_filter_strength" is defined in h263.c, but
> >> >> the h263 loopfilter functions (in the .asm file) are not optimized
> >> >> out (even though their function pointers are never assigned).
> >> >> ---
> >> >> libavcodec/x86/dsputil.asm | 3 ++-
> >> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >> >
> >> > This breaks building of mplayer
> >> That is another project.
> > Thats absolutely true but still no reason to break it if it can be
> > avoided easily
> I do not have mplayer installed, and thus I can not follow this.
> It is just bogus to mention such thing at all.
consider these 2 alternatives:
A1: patch applied
A2: mplayer1 compile is broken
A3: mplayer1 is fixed
A4: mplayet1 compiles again
B1: i post a note that this breaks mplayer
B2: mplayer1 is fixed
B3: patch applied
its the same work either way and also done by the same developers,
noone has more work BUT the difference, mplayer compile didnt break in
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel