[FFmpeg-devel] [PATCH] Use correct colorspace in Cinepak decoder.

u-bo1b at 0w.se u-bo1b at 0w.se
Tue Feb 19 12:53:10 CET 2013

On Tue, Feb 19, 2013 at 06:24:25AM -0500, compn wrote:
> >eliminating it. The second patch fixes this by rejecting unsafe strips.
> in ffmpeg usually we print a message "invalid amount of strips" and
> then continue decoding of the file.
> so the user is warned, but at least can still play his/her file.

Given that strips are frame-wide for all samples and encoders known to me,
rejecting per strip implies rejecting the whole file.

A safe and efficient approach would be to be able to adjust the frame
size up to a multiple of 4 (mplayer actually seems to do that?).
Is there any way to properly set this from inside the decoder?

Another way is moving the check from per-strip to per-block, to treat
"partial" blocks separately (the check will cost some performance).

Possibly this would be nice as the next improvement but right now I do
not feel that the problem is a regression.


More information about the ffmpeg-devel mailing list