[FFmpeg-devel] [PATCH 2/3] pmpdec: fix signedness

Nicolas George nicolas.george at normalesup.org
Sun Feb 24 23:42:23 CET 2013

Le sextidi 6 ventôse, an CCXXI, Michael Niedermayer a écrit :
> a comparission between signed and unsigend int is of unsigned type.
> posix gurantees int has at least 32bit
> also theres a EOF check in the loop
> i guess in a few minutes some language lawyer will tell us that the
> i++ is undefined behavior :)
> (which has no practical relevance here but probably better to fix it
>  anyway)

There is a more severe problem with i being signed but used as unsigned a
few lines below, where it is used as argument to av_add_index_entry().


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130224/a2aa1333/attachment.asc>

More information about the ffmpeg-devel mailing list