[FFmpeg-devel] [PATCH 1/2] libvpx: allow setting 0 for min quantizer

Werner Robitza werner.robitza at gmail.com
Mon Feb 25 18:58:51 CET 2013

> please dont add code in one patch that then gets fixed in the next
> also each issue should be dealt with in a seperate patch
> 1 patch to fix the qmin bug
> 1 patch to add bounds checking

Apologies. My first patch I ever contributed anywhere.

> also qmin >= qmax should not be silently ignored

In that case, qmin won't be changed and is set to the default (4), but a
warning would be appropriate.

I will send patches to deal with each issue separately.


More information about the ffmpeg-devel mailing list