[FFmpeg-devel] [PATCH] avformat: avisynth demuxer rewrite
qyot27 at gmail.com
Tue Feb 26 23:47:42 CET 2013
On Tue, Feb 26, 2013 at 9:56 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> please split the addition of compat headers into a seperate patch and
> submit all patches as attachments not a link, this makes commenting
> on the mailing list alot easier.
> Also please use git format-patch or git send-email so the patches
> come with commit messages and authorship information
The only reason I didn't attach was that I was concerned about the
mimetype getting mangled. I'll see about git send-email, and I'll
definitely get the compat headers split from the main patch.
> The patchset replaces avisynth.c, maybe it was already discussed and
> i forgot but is all functionality from avisynth.c still available in
> the new ?
> that is would all users of all platforms who could use it before still
> use it ?
> if not then a seperate new avxsynth.c would probably be a better idea
I'm certainly not aware of anything that the old one did that the new
> ffmpeg is not the only application that uses libavformat so this
> might be a much bigger problem than you think.
> what you basically suggest is that no application that uses libavformat
> is allowed to use atexit() anymore
> also your patch replaces 6 out of 30 occurances of exit() in ffmpeg.c
> this does look quite incomplete ...
> an alternative solution (that may or may not work) would be to
> register your own atexit handler when the avxsynth demuxer is opened
> and if the callback gets called do the free / or not do the free from
> it but set a global flag that prevents subsequent access from
> read_close(). I dont know if that would have issues or how ugly it
> would be but i guess you too would prefer if libavformat+avxsynth
> could be used from applications that do use atexit in a similar way
> to ffmpeg.c
I'll forward this over and see what their response is.
Although I'll note that the patch for this I linked to from Github
replaces most of the occurrences of exit() in ffmpeg.c, but that's
irrelevant if the atexit usage can be reconciled.
More information about the ffmpeg-devel