[FFmpeg-devel] [PATCH] mp3dec: Fix VBR bit rate parsing

Michael Niedermayer michaelni at gmx.at
Wed Feb 27 12:56:21 CET 2013

On Tue, Feb 26, 2013 at 10:28:42PM -0800, Alexander Kojevnikov wrote:
> Commit 6776a8f[0] introduced a regression in calculation[1] of the bit
> rate of VBR streams. Instead of keeping the bit rate from the Xiph
> tag, it now overrides it during parsing with the bit rate from one of
> the frames.
> Attached patch should fix it. It relies on the assumption[2] that the
> Xiph/Info tag has "Xiph" id string for VBR streams and "Info" for CBR.

xiph ?

and it seems the patch breaks "make fate"
--- ./tests/ref/lavf-fate/mp3   2013-02-26 02:17:04.526545833 +0100
+++ tests/data/fate/lavf-fate-mp3       2013-02-27 12:50:36.909166861 +0100
@@ -1,3 +1,3 @@
-40a4e41ae74ec8dacdf02402831a6a58 *./tests/data/lavf-fate/lavf.mp3
-97230 ./tests/data/lavf-fate/lavf.mp3
+98ed29febe5ddfe85eef0d3460701141 *./tests/data/lavf-fate/lavf.mp3
+95970 ./tests/data/lavf-fate/lavf.mp3
 ./tests/data/lavf-fate/lavf.mp3 CRC=0x6c9850fe


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130227/400f3ea3/attachment.asc>

More information about the ffmpeg-devel mailing list