[FFmpeg-devel] [PATCH] fate: disable globbing when calling shell functions.

Michael Niedermayer michaelni at gmx.at
Wed Jan 2 23:49:06 CET 2013

On Wed, Jan 02, 2013 at 11:41:51PM +0100, Nicolas George wrote:
> Some of the filters tests use globbing characters, especially
> brackets for filter pad labels. While most of these strings
> are way too complicated to ever match an existing file name
> and are therefore kept unchanged in the command line (an old
> misfeature of the shell language that happens to be convenient
> here), at least one use is simple enough to match random files
> lying in the current directory. If that happens, the string,
> that was meant to be kept verbatim, is replaced by the file
> name, and that causes the test to fail (or worse).
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  tests/fate-run.sh |    4 ++++
>  1 file changed, 4 insertions(+)
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 9cd872b..0520d62 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -166,6 +166,10 @@ lavfitest(){
>  mkdir -p "$outdir"
> +# Disable globbing: command arguments may contain globbing characters and
> +# must be kept verbatim
> +set -f

should be ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130102/3486dac1/attachment.asc>

More information about the ffmpeg-devel mailing list