[FFmpeg-devel] [PATCH]Improve pix_fmt detection for the native jpeg2000 decoder

[Paul B Mahol]

On 7/7/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Jul 07, 2013 at 09:15:25PM +0200, Carl Eugen Hoyos wrote:
>> On Sunday 07 July 2013 12:18:14 am Michael Niedermayer wrote:
>> > On Sat, Jul 06, 2013 at 03:34:50PM +0200, Carl-Eugen Hoyos wrote:
>> > > Hi!
>> > >
>> > > Attached patch fixes ticket #2683 for me to some degree (-vcodec
>> > > libopenjpeg was implicitely used before, it has to be passed
>> > > explicitely now), heavily based on a patch by Michael Bradshaw.
>> > >
>> > > Now with attachment.
>> > >
>> > > Please review, Carl Eugen
>> >
>> > Breaks decoding of
>> > testfiles_jp2/file2.jp2
>> > testfiles_jp2/file3.jp2
>>
>> Both files fail to decode correctly with current FFmpeg without
>> libopenjpeg,
>> file2.jp2 even fails to decode correctly with libopenjpeg enabled and
>> used,
>> an incorrect pix_fmt is shown for both files.
>> (file3.jp2 decodes fine with libopenjpeg but changes pix_fmt / inserts a
>> filter without telling the user, I consider this a bug, it is a
>> regression.)
>> With my patch, the correct pix_fmt is shown and both files can be decoded
>>
>> when libopenjpeg is enabled and used.
>>
>> New patch attached that spams the console with warnings about
>> our "non-experimental" decoder.
>>
>> Please review, Carl Eugen
>
> it spams even when libopenjpeg is used, please dont waste more time on
> this warning and remove it.
>
>
> [...]
>> +        av_log(s, AV_LOG_WARNING, "native openjpeg2000 decoder does not
>> completely support %s, "
>
> "native openjpeg2000 decoder" ?
> its called jpeg2000
>

What not finally fix native decoder?

> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Rewriting code that is poorly written but fully understood is good.
> Rewriting code that one doesnt understand is a sign that one is less smart
> then the original author, trying to rewrite it will not make it better.
>