[FFmpeg-devel] [PATCH]Support muxing more qcelp samples in mov

[Michael Niedermayer]

On Tue, Jul 09, 2013 at 08:55:23AM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > > are "official" qcelp in mov files also stored in 
> > > > this inefficient way ?
> > > 
> > > All files in our collection have constant packet size.
> > 
> > The way i understand the patch is that it increases 
> > the size of all packets to 35 bytes
> 
> That is what the patch does.
> 
> > (which can waste alot of space if many are
> > smaller)
> 
> (waste compared to what? ffmpeg currently silently 
> muxes unplayable files.)
> 
> > What i meant was, do we have samples that also 
> > bloat packet up in such way?
> 
> No.
> (Actually I am not sure but it is ok imo to 
> assume that we don't have such a sample.)
> 

> > and do we have samples that have smaller packets ?
> 
> Yes (but one of them does not play with QT - it 
> does after remuxing with my patch - I still don't 
> understand why another one works).
> 

> > Which would imply that theres a more efficient 
> > way to mux them
> 
> Of course.
> Using an encoder with a specified bitrate allows the 
> muxer to mux with the exact specified bitrate.
> Since ffmpeg does not scan the whole (qcp) file 
> before remuxing, it cannot know the optimal muxing 
> rate.
> 
> Or do I miss something?

the muxer can use AVCodecContext.bit_rate or rc_max_rate or allow the
user to specify the muxrate (somewhat similar to mpeg-ps/ts)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130709/228559c1/attachment.asc>