[FFmpeg-devel] [PATCH]Do not ignore rm_assemble_video_frame() return codes

Michael Niedermayer michaelni at gmx.at
Fri Jul 12 21:43:00 CEST 2013


On Fri, Jul 12, 2013 at 08:29:11PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> rm_assemble_video_frame() contains several checks that return error codes, but 
> they are all ignored in the calling functions ff_rm_parse_packet() and 
> rm_read_packet().
> (I suspect rdt_parse_packet() misinterprets the return 
> values, but this is unrelated.)
> Attached patch should fix the passing of the error codes from 
> rm_assemble_video_frame().
> 
> Please review, Carl Eugen

>  rmdec.c |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> fb120cfdd3380823e24867f472b02f0f393b6541  patchrmassemble.diff

LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130712/2b9f97a3/attachment.asc>


More information about the ffmpeg-devel mailing list