[FFmpeg-devel] One pass volume normalization (ebur128)

[Paul B Mahol]

On 7/13/13, Jan Ehrhardt <phpdev at ehrhardt.nl> wrote:
> Paul B Mahol in gmane.comp.video.ffmpeg.devel (Sat, 13 Jul 2013 19:28:05
> +0000):
>>On 7/13/13, Jan Ehrhardt <phpdev at ehrhardt.nl> wrote:
>>> --- a/libavfilter/x86/af_volume_init.c
>>> +++ b/libavfilter/x86/af_volume_init.c
>>> @@ -39,7 +39,7 @@ av_cold void ff_volume_init_x86(VolumeContext *vol)
>>>      enum AVSampleFormat sample_fmt =
>>> av_get_packed_sample_fmt(vol->sample_fmt);
>>>
>>>      if (sample_fmt == AV_SAMPLE_FMT_S16) {
>>> -        if (EXTERNAL_SSE2(mm_flags) && vol->volume_i < 32768) {
>>> +        if (EXTERNAL_SSE2(mm_flags) && vol->volume_i < 32768 &&
>>
>>Why? This is suboptimal.
>
> I really would not know. It was already there in Clement's patch at
> http://permalink.gmane.org/gmane.comp.video.ffmpeg.devel/159978
>
> Feel free to make it optimal.

But you could remove that hunk and test it.