[FFmpeg-devel] [PATCH] Matroska demuxer adds WebVTT support

wm4 nfxjfg at googlemail.com
Tue Jul 16 10:23:07 CEST 2013


On Mon, 15 Jul 2013 17:02:55 -0700
Matthew Heaney <matthewjheaney at google.com> wrote:

> +static int matroska_parse_webvtt(MatroskaDemuxContext *matroska,
> +                                 MatroskaTrack *track,
> +                                 AVStream *st,
> +                                 uint8_t *data, int data_len,
> +                                 uint64_t timecode,
> +                                 uint64_t duration,
> +                                 int64_t pos)
> +{
[...]

Can I ask why there is subtitle parsing in the Matroska demuxer? I find
this a bit odd. Why split them into side-data, instead of just
leaving the packet as-is? Not even ASS subtitles, a rather complicated
format, require special treatment in the demuxer. (Not anymore; it used
to be the case that ASS packets were converted into special
ffmpeg-specific packets, but that was recently fixed AFAIK.)


More information about the ffmpeg-devel mailing list