[FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale: allow overriding in/out yuv colorspace type

Michael Niedermayer michaelni at gmx.at
Sat Jul 20 22:22:15 CEST 2013


On Mon, Jul 15, 2013 at 07:31:58PM +0000, Paul B Mahol wrote:
> On 7/15/13, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
> > On Mon, Jul 15, 2013 at 01:19:34AM +0200, Michael Niedermayer wrote:
> >> > That is not exacly same, as qcif/cif/ .. are not listed at all.
> >> >
> >> > Also it seems little akward to me that in same option one can give
> >> > custom matrix and already available one.
> >>
> >> yes
> >>
> >> Do people want me to change the patch somehow or are they ok with it
> >> as it is. I dont mind changing it but such request must come with
> >> understanding of the sideeffects
> >
> > Not that I really mind, but if we have multiple options to set the
> > same thing how do we decide which to use? E.g. if the user set both?
> 
> Well, if type is set to custom then matrix is read.
> If matrix is set but type is not custom, warning is displayed.
> 
> I do not insist on anything, you can commit whatever you like.

restructured a bit and applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130720/61c8c381/attachment.asc>


More information about the ffmpeg-devel mailing list