[FFmpeg-devel] [PATCH] jpeg2000dec: simplify jpeg2000_read_bitstream_packets()

Michael Niedermayer michaelni at gmx.at
Wed Jul 24 04:14:19 CEST 2013


On Tue, Jul 23, 2013 at 10:21:27PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > +    atom_end  = bytestream2_tell(&s->g) + atom_size - 8;
> 
> > +    if (bytestream2_get_bytes_left(&s->g) < atom_size || 
> > atom_end < atom_size)
> 
> Could you explain what atom_end < atom_size is supposed 
> to check?

integer overflow


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130724/1add966b/attachment.asc>


More information about the ffmpeg-devel mailing list