[FFmpeg-devel] [PATCH 2/5] libxvid: add working lumimasking

[Michael Niedermayer]

On Sun, Jul 28, 2013 at 04:12:56PM -0700, Timothy Gu wrote:
> On Jul 28, 2013 4:07 PM, "Michael Niedermayer" <michaelni at gmx.at> wrote:
> >
> > On Sun, Jul 28, 2013 at 03:54:52PM -0700, Timothy Gu wrote:
> > > On Sunday, July 28, 2013, Michael Niedermayer wrote:
> > > >
> > > > On Sat, Jul 27, 2013 at 04:32:31PM -0700, Timothy Gu wrote:
> [...]
> > > > > +static const AVOption options[] = {
> > > > > +    { "lumi_masking_mode", "HVS masking mode",
> > >  OFFSET(lumi_masking_mode), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 2, VE,
> > > "lumi_masking_mode" },
> > > > > +        { "off",           NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 0
> },
> > > INT_MIN, INT_MAX, VE, "lumi_masking_mode" },
> > > > > +        { "lumi",          NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 1
> },
> > > INT_MIN, INT_MAX, VE, "lumi_masking_mode" },
> > > > > +        { "variance",      NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 2
> },
> > > INT_MIN, INT_MAX, VE, "lumi_masking_mode" },
> > > > > +    { NULL },
> > > > > +};
> > > >
> > > > this doesnt allow both to be specified
> > >
> > > Xvid does not allow both to be specified
> >
> > i thought one could add 2 plugins one for lumi and one for variance
> > masking
> 
> No, it is just one big plugin with a switch to use either method.

i dont see how this would be a problem on its own
one could load the plugin twice with the switch being different for
each


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130729/1c8ed077/attachment.asc>