[FFmpeg-devel] [PATCH]Error out if libcdio-paranoia is not found in configure
ubitux at gmail.com
Sat Jun 1 17:47:52 CEST 2013
On Sat, Jun 01, 2013 at 03:31:05PM +0000, Carl Eugen Hoyos wrote:
> Clément Bœsch <ubitux <at> gmail.com> writes:
> > On Sat, Jun 01, 2013 at 02:21:01PM +0000, Carl Eugen Hoyos wrote:
> > > Clément Bœsch <ubitux <at> gmail.com> writes:
> > >
> > > > > + die "ERROR: libcdio-paranoia not found"
> > > > > fi
> > > >
> > > > Maybe just "require_pkg_config libcdio_paranoia"?
> I am actually against this (see below).
> > > On second thought:
> > > Does libcdio require pkg_config?
> > I don't know if any project actually "requires"
> > pkg-config, but it seems to be distributed with the
> > necessary .pc files. And since solving your problem
> > is actually the purpose of pkg-config, I thought it
> > was the appropriate to use it.
> I believe we should try hard to avoid using it,
> especially in this case when nobody complained
> that the library wasn't found (but that
> configure is broken).
I think I missed the point of your patch (the line split you introduced
made me think you were adding the second check while it was already
But now, I wonder about a few things; first, do we want auto-detection?
(it's not indicated in the help). If it's the case, then it's in the
correct place, but looks like it has the wrong behaviour: it should be
auto-disabled and not error out, just like the others check around IMO.
OTOH, if it's not supposed to be auto-detected, why isn't it with the
other libraries checks below, where they error out?
I believe we should consider clarifying all this stuff.
About pkg-config, I understand you don't want to change that in this
commit, it was obviously unrelated. Though, I think that's a more correct
thing to do.
> But otoh, if it works for you, I of course cannot
I didn't test anything.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 490 bytes
Desc: not available
More information about the ffmpeg-devel