[FFmpeg-devel] [PATCH/WIP]Add an unscaled GBRAP16 -> RGB48/64 wrapper

Michael Niedermayer michaelni at gmx.at
Mon Jun 10 02:07:51 CEST 2013


On Sun, Jun 09, 2013 at 11:13:24PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > > this patch seems to break fate
> > > 
> > > I only sent this patch to show how I tested the first 
> > > patch (that would need an ok from you if it I should 
> > > commit).
> > 
> > i understand that but the failures looked strange:
> > so i thought they should be looked at to make sure 
> > theres no bug in the first patch
> 
> Aren't they just coming from the missing yuv420p -> 
> gbrap16 path?

I see
"Segmentation fault (core dumped)" in 
tests/data/fate/filter-pixfmts-null.err

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130610/3848641e/attachment.asc>


More information about the ffmpeg-devel mailing list