[FFmpeg-devel] [PATCH] lavu: Add RIPEMD hashing

Michael Niedermayer michaelni at gmx.at
Sun Jun 16 01:17:32 CEST 2013


On Sat, Jun 15, 2013 at 04:18:15PM -0300, James Almer wrote:
> On 15/06/13 6:21 AM, Michael Niedermayer wrote:
> >> +static uint32_t rol(uint32_t value, uint32_t bits) {
> >> +    return (value << bits) | (value >> (32 - bits));
> >> +}
> > 
> > 
> > should be always_inline as its just 1 instruction on many architectures
> > 
> > also, if you plan to maintain this in the future you should add
> > yourself to MAINTAINERS for this
> 
> Added myself to MAINTAINERS, made rol() a #define to be used inside the transform 
> functions and pushed to my public repo alongside the other patches.

merged

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130616/5771d2fa/attachment.asc>


More information about the ffmpeg-devel mailing list