[FFmpeg-devel] [PATCH 2/4] x86/qpel: move fullpel and l2 functions to separate file.

[Michael Niedermayer]

On Sun, Mar 03, 2013 at 03:47:10PM -0800, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje" <rsbultje at gmail.com>
> 
> This way, they can be shared between mpeg4qpel and h264qpel without
> requiring either one to be compiled unconditionally.
> ---
>  libavcodec/x86/Makefile     |   4 +-
>  libavcodec/x86/dsputil.asm  | 192 ---------------------------------
>  libavcodec/x86/hpeldsp.asm  |  41 -------
>  libavcodec/x86/qpelbase.asm | 254 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 257 insertions(+), 234 deletions(-)
>  create mode 100644 libavcodec/x86/qpelbase.asm

doesnt build:
`ff_avg_pixels8_mmxext' referenced in section `.text' of libavcodec/libavcodec.a(dsputil_mmx.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(qpelbase.o)
`ff_put_pixels8_mmxext' referenced in section `.text' of libavcodec/libavcodec.a(dsputil_mmx.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(qpelbase.o)
`ff_put_pixels8_mmxext' referenced in section `.text' of libavcodec/libavcodec.a(dsputil_mmx.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(qpelbase.o)
`ff_put_pixels8_l2_mmxext' referenced in section `.text' of libavcodec/libavcodec.a(dsputil_mmx.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(qpelbase.o)
`ff_put_pixels8_l2_mmxext' referenced in section `.text' of libavcodec/libavcodec.a(dsputil_mmx.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(qpelbase.o)
`ff_put_pixels8_l2_mmxext' referenced in section `.text' of libavcodec/libavcodec.a(dsputil_mmx.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(qpelbase.o)
(above is a random sample of errors, its many pages of errors)

with 1/4:
libavcodec/dsputil.c:1312:6: error: no previous prototype for ‘ff_put_pixels8x8’ [-Werror=missing-prototypes]
libavcodec/dsputil.c:1315:6: error: no previous prototype for ‘ff_avg_pixels8x8’ [-Werror=missing-prototypes]
libavcodec/dsputil.c:1318:6: error: no previous prototype for ‘ff_put_pixels16x16’ [-Werror=missing-prototypes]
libavcodec/dsputil.c:1321:6: error: no previous prototype for ‘ff_avg_pixels16x16’ [-Werror=missing-prototypes]

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130305/0bf68278/attachment.asc>