[FFmpeg-devel] [PATCH 02/15] lavfi/asetnsamples: raise filter_frame() error.

Clément Bœsch ubitux at gmail.com
Wed Mar 13 19:02:08 CET 2013


On Wed, Mar 13, 2013 at 04:06:25PM +0100, Nicolas George wrote:
> Le tridi 23 ventôse, an CCXXI, Clement Boesch a écrit :
> > +    if (ret == AVERROR_EOF) {
> > +        do {
> > +            ret = push_samples(outlink);
> > +        } while (ret > 0);
> > +    }
> 
> while ((ret = push_samples(outlink)) < 0)
>     ;
> 
> would be a little more compact and not, IMHO, less readable, but that does
> not matter much.
> 

If you didn't have switched the condition I would have trust you ;)

I'd prefer to keep it that way. The maintainer is free to change it later.

[...]

I'll push the patchset soon, thanks.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130313/8e170734/attachment.asc>


More information about the ffmpeg-devel mailing list