[FFmpeg-devel] [PATCH] ffplay: remove options skiploop, skipidct, skipframe

[Marton Balint]

On Sun, 17 Mar 2013, Stefano Sabatini wrote:

> The corresponding codec options (skip_loop, skip_idct, skip_frame) can be
> set in a more flexible way as codec options.
>
> This technically causes a user interface break, since the options were
> not even documented and we just released a major version that should not
> be a serious issue.
> ---
> ffplay.c |    9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/ffplay.c b/ffplay.c
> index 726d28c..4b2c6fa 100644
> --- a/ffplay.c
> +++ b/ffplay.c
> @@ -296,9 +296,6 @@ static int fast = 0;
> static int genpts = 0;
> static int lowres = 0;
> static int idct = FF_IDCT_AUTO;
> -static enum AVDiscard skip_frame       = AVDISCARD_DEFAULT;
> -static enum AVDiscard skip_idct        = AVDISCARD_DEFAULT;
> -static enum AVDiscard skip_loop_filter = AVDISCARD_DEFAULT;
> static int error_concealment = 3;
> static int decoder_reorder_pts = -1;
> static int autoexit;
> @@ -2476,9 +2473,6 @@ static int stream_component_open(VideoState *is, int stream_index)
>         avctx->lowres= codec->max_lowres;
>     }
>     avctx->idct_algo         = idct;
> -    avctx->skip_frame        = skip_frame;
> -    avctx->skip_idct         = skip_idct;
> -    avctx->skip_loop_filter  = skip_loop_filter;
>     avctx->error_concealment = error_concealment;
>
>     if(avctx->lowres) avctx->flags |= CODEC_FLAG_EMU_EDGE;
> @@ -3377,9 +3371,6 @@ static const OptionDef options[] = {
>     { "genpts", OPT_BOOL | OPT_EXPERT, { &genpts }, "generate pts", "" },
>     { "drp", OPT_INT | HAS_ARG | OPT_EXPERT, { &decoder_reorder_pts }, "let decoder reorder pts 0=off 1=on -1=auto", ""},
>     { "lowres", OPT_INT | HAS_ARG | OPT_EXPERT, { &lowres }, "", "" },
> -    { "skiploop", OPT_INT | HAS_ARG | OPT_EXPERT, { &skip_loop_filter }, "", "" },
> -    { "skipframe", OPT_INT | HAS_ARG | OPT_EXPERT, { &skip_frame }, "", "" },
> -    { "skipidct", OPT_INT | HAS_ARG | OPT_EXPERT, { &skip_idct }, "", "" },
>     { "idct", OPT_INT | HAS_ARG | OPT_EXPERT, { &idct }, "set idct algo",  "algo" },
>     { "ec", OPT_INT | HAS_ARG | OPT_EXPERT, { &error_concealment }, "set error concealment options",  "bit_mask" },
>     { "sync", HAS_ARG | OPT_EXPERT, { .func_arg = opt_sync }, "set audio-video sync. type (type=audio/video/ext)", "type" },

LGTM, thanks.

Marton