[FFmpeg-devel] [PATCH 01/14] lavfi: add common code to handle options parsing.

Nicolas George nicolas.george at normalesup.org
Sun Mar 17 13:39:14 CET 2013


Le septidi 27 ventôse, an CCXXI, Stefano Sabatini a écrit :
> Could you elaborate on this (especially about the last point)?

There are currently a few filters that implement a parser more complex than
options parsing. Some of them use a syntax that is similar to options
parsing, so the solution of transforming the argument into a single string
option with shorthand will lead the user into escaping hell.

I am thinking of af_pan in particular: it implements the
"out_channel=in_channels:out_channel=in_channels" syntax, but out_channel
depend on the requested layout, and therefore can not be stored as options;
furthermore, the = can become a <, and it has a different semantic.

> My medium term plan is to make all filters support options, so we can
> simplify and generalize option handling, for example to support a
> filter(foo="1", bar="string") syntax.

That is an interesting plan, and I think I support it in principle.

> Yes, but it is weird to enable option parsing *only* when shorthand is
> defined. That said, I'm not against this if it is meant as an
> intermediary step towards the final end.

Ok, let us consider this a starting point.

Any technical comments on the patch series?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130317/60a98fc6/attachment.asc>


More information about the ffmpeg-devel mailing list