[FFmpeg-devel] [PATCH] ffplay: remove -bug option

[Marton Balint]

On Tue, 19 Mar 2013, Stefano Sabatini wrote:

> The same option can be set as a codec option. Syntax unchanged.
> ---
> doc/ffplay.texi |    2 --
> ffplay.c        |    3 ---
> 2 files changed, 5 deletions(-)
>
> diff --git a/doc/ffplay.texi b/doc/ffplay.texi
> index ee160a0..5387540 100644
> --- a/doc/ffplay.texi
> +++ b/doc/ffplay.texi
> @@ -106,8 +106,6 @@ duration, the codec parameters, the current position in the stream and
> the audio/video synchronisation drift. It is on by default, to
> explicitly disable it you need to specify @code{-nostats}.
>
> - at item -bug
> -Work around bugs.
> @item -fast
> Non-spec-compliant optimizations.
> @item -genpts
> diff --git a/ffplay.c b/ffplay.c
> index 4b2c6fa..e7a24e0 100644
> --- a/ffplay.c
> +++ b/ffplay.c
> @@ -291,7 +291,6 @@ static int show_status = 1;
> static int av_sync_type = AV_SYNC_AUDIO_MASTER;
> static int64_t start_time = AV_NOPTS_VALUE;
> static int64_t duration = AV_NOPTS_VALUE;
> -static int workaround_bugs = 1;
> static int fast = 0;
> static int genpts = 0;
> static int lowres = 0;
> @@ -2465,7 +2464,6 @@ static int stream_component_open(VideoState *is, int stream_index)
>     }
>
>     avctx->codec_id = codec->id;
> -    avctx->workaround_bugs   = workaround_bugs;
>     avctx->lowres            = lowres;
>     if(avctx->lowres > codec->max_lowres){
>         av_log(avctx, AV_LOG_WARNING, "The maximum value for lowres supported by the decoder is %d\n",
> @@ -3366,7 +3364,6 @@ static const OptionDef options[] = {
>     { "f", HAS_ARG, { .func_arg = opt_format }, "force format", "fmt" },
>     { "pix_fmt", HAS_ARG | OPT_EXPERT | OPT_VIDEO, { .func_arg = opt_frame_pix_fmt }, "set pixel format", "format" },
>     { "stats", OPT_BOOL | OPT_EXPERT, { &show_status }, "show status", "" },
> -    { "bug", OPT_INT | HAS_ARG | OPT_EXPERT, { &workaround_bugs }, "workaround bugs", "" },
>     { "fast", OPT_BOOL | OPT_EXPERT, { &fast }, "non spec compliant optimizations", "" },
>     { "genpts", OPT_BOOL | OPT_EXPERT, { &genpts }, "generate pts", "" },
>     { "drp", OPT_INT | HAS_ARG | OPT_EXPERT, { &decoder_reorder_pts }, "let decoder reorder pts 0=off 1=on -1=auto", ""},

LGTM, thanks.

Marton