[FFmpeg-devel] [PATCH 1/2] libavutil/libavfilter: add opencl wrapper to ffmpeg

Wei Gao highgod0401 at gmail.com
Sun Mar 24 12:05:59 CET 2013


2013/3/24 Stefano Sabatini <stefasab at gmail.com>

> On date Sunday 2013-03-24 18:36:37 +0800, Wei Gao encoded:
> > 2013/3/24 Stefano Sabatini <stefasab at gmail.com>
> [...]
> > OK, I will fix them and re-submit, one more question, the following
> comment
> > you give me, I didn't get what you mean,sorry
> >
> > > +    if (status != CL_SUCCESS) {
> > > +
>  av_log(&openclutils,AV_LOG_ERROR,"generate_bin_from_kernel_source
> > error,clGetProgramInfo:%s\n",opencl_errstr(status));
> > > +        return AVERROR_EXTERNAL;
> > > +    }
> > > +    devices = av_mallocz(sizeof(cl_device_id) * numdevices);
> > > +    if (!devices)
> > > +        return AVERROR(ENOMEM);
> > > +    /* grab the handles to all of the devices in the program. */
> > > +    status = clGetProgramInfo(program,
> > > +                              CL_PROGRAM_DEVICES,
> > > +                              sizeof(cl_device_id) * numdevices,
> > > +                              devices,
> > > +                              NULL);
> >
> > this code could be possibly be factorized
>
> Discard the comment, not really important.
>
OK, thanks, I will re-submit the patch later. It may take you a lot of time
to review the patch.Thanks for your reviewing.

Thanks

> --
> FFmpeg = Fierce and Foolish Magical Perfectionist Epic Gnome
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list