[FFmpeg-devel] [PATCH] video stabilization plugins using vid.stab library

Stefano Sabatini stefasab at gmail.com
Sat Mar 30 15:10:33 CET 2013


On date Saturday 2013-03-30 12:34:26 +0000, Paul B Mahol encoded:
> On 3/29/13, Clement Boesch <ubitux at gmail.com> wrote:
> > On Thu, Mar 28, 2013 at 11:24:11PM +0100, Georg Martius wrote:
> >> Hi,
> >>
> >> I changed the interface of my library to have a prefixe for every function
> >> and
> >> type.
> >> Attached is the patch against master (I used git rebase, thanks) so you
> >> can
> >> forget the previous patches.
> >>
> >> Regards,
> >>   Georg
> >>
> >> On Saturday 23 March 2013 13:28:55 Michael Niedermayer wrote:
> >> > On Tue, Mar 19, 2013 at 12:43:39AM +0100, Georg Martius wrote:
> >> > > I changed what you suggested and added also parts to the configure
> >> > > script
> >> > > and Changelog.
> >> > >
> >> > > I am somehow to stupid to get git squash my changes into one patch
> >> > > file,
> >> > > prob. because I didn't do them in a separate branch. I hope you can
> >> > > work
> >> > > with the
> >> > you can reorder and squash things using git rebase -i (see the manual)
> >> >
> >> > [...]
> >
> >> From 9e8ace6a91b7bb23c83c4e2dbe1e563fcaf1ec3b Mon Sep 17 00:00:00 2001
> >> From: Georg Martius <georg.martius at web.de>
> >> Date: Thu, 28 Mar 2013 22:59:16 +0100
> >> Subject: [PATCH] video stabilization plugins using vid.stab library with
> >>  (configure and renamed interface)
> >>
> >>
> >> Signed-off-by: Georg Martius <georg.martius at web.de>
> >> ---
> >>  Changelog                  |    1 +
> >>  configure                  |    6 +
> >>  libavfilter/Makefile       |    2 +
> >>  libavfilter/allfilters.c   |    2 +
> >>  libavfilter/vf_stabilize.c |  336 +++++++++++++++++++++++++++++++++++++
> >>  libavfilter/vf_transform.c |  401
> 
> Why such generic names for filters (exp transform)?
> 
> Also name of filters should have something that says it is part of another lib.

The convention adopted is to use the name of the library in the name,
e.g. like in vf_libopencv.c, but there are exception if the name of
the library is not ambiguous (e.g. frei0r, sox).
-- 
FFmpeg = Fiendish and Fascinating Mysterious Picky Elitarian Goblin


More information about the ffmpeg-devel mailing list