[FFmpeg-devel] [PATCH 02/12 v2] doc: Explain the various logevel settings

[Derek Buitenhuis]

On 2013-03-31 2:02 PM, Stefano Sabatini wrote:
>>>  @item panic
>>> +Only show errors which could affect the state of a user's system. This is
>>> +not actually used for anything currently.
> 
> "errors which could affect the state of a user's system"
> 
> uhmmm, this is very vague. Also, from a technical point of view even a
> bit change is affecting the state of the user's system. I still
> suggest to mirror the log.h docs, and say something like:
> 
> Only show fatal errors which would lead to the process crash. This is
> not actually used for anything currently.

Why don't you people give me a freaking consistent definition of what PANIC
is in the context FFmpeg! This is the THIRD DIFFERENT explanation I've been given.

Make up your damn minds.

(This is probably because PANIC makes NO SENSE in the context of FFmpeg in the
first place, and shouldn't exist!)

>>>  @item fatal
>>> +Only show fatal errors. These are errors after which the process absolutely
>>> +cannot continue after.
> 
>>>  @item error
>>> +Show all errors and panics, including ones which can be recovered from. 
> 
> Nit: Show all errors, including...
> 
> "panics" sounds weird and scary, since you don't define what "panics"
> are.

It is defined directly above.

>>>  @item info
>>> +Show information from libavcodec, libavformat, and other libraries during
>>> +processing, if they provide it. This is in addition to warnings and errors.
>>> +This is the default value.
> 
> After re-reading, it's weird to mention the libraries here, this
> implicitly assumes that the other log levels don't deal with
> libraries. I suggest this simplification:
> 
> Show informative messages during processing. This is in addition to
> warnings and errors. This is the default value.

Fixed locally.

- Derek