[FFmpeg-devel] [PATCH 2/5] fate: avoid framemd5, use framecrc its faster

compn tempn at twmi.rr.com
Thu May 9 15:06:04 CEST 2013


On Thu, 9 May 2013 14:44:38 +0200, Reimar Döffinger wrote:
>On Thu, May 09, 2013 at 08:39:25AM -0400, compn wrote:
>> On Wed, 08 May 2013 18:24:25 +0200, Reimar Döffinger wrote:
>> >Michael Niedermayer <michaelni at gmx.at> wrote:
>> >
>> >>Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
>> >
>> >I disagree with this, CRC can easily miss structural changes, particularly with 
>> 
>> in my tests over the years, crc has been good enough for me.
>> 
>> btw , why not just have both? make it a fate option to use crc or md5.
>> (i guess means having both crc and md5 results too)
>
>Overkill, and needs space in git to store both references.

we could have seperate repo, if thats even a problem.

>At least personally I'd rather have Michael go ahead with what he has,
>unless we agree on something better.

anyone check if our md5sum implementation was the fastest? is it
optimized for ssse3? yasm? can it be offloaded to gpu?

-compn


More information about the ffmpeg-devel mailing list