[FFmpeg-devel] [PATCH 1/2] lavfi/deshake: share Opencl buffer for deshake

Wei Gao highgod0401 at gmail.com
Tue May 14 02:18:39 CEST 2013


2013/5/12 Stefano Sabatini <stefasab at gmail.com>

> On date Tuesday 2013-05-07 13:00:36 +0800, Wei Gao encoded:
> >
>
> > From efbb6ba4ff9bb479e9ab03cf75a6f25f542d780d Mon Sep 17 00:00:00 2001
> > From: highgod0401 <highgod0401 at gmail.com>
> > Date: Tue, 7 May 2013 12:55:44 +0800
> > Subject: [PATCH 1/2] lavfi/deshake: share Opencl buffer for deshake
> >
> > ---
> >  libavfilter/deshake.h        |  2 ++
> >  libavfilter/deshake_opencl.c | 58
> +++++++++++++++++++++++++++++++-------------
> >  2 files changed, 43 insertions(+), 17 deletions(-)
> >
>
>
> I confess that I don't like this kind of design. A filter should not
> access the context of other filters in the filtergraph, or things will
> go berserk if you want to implement dynamic behavior, for example in
> case a filter is auto-inserted between them.
>
> Also I think the correct design should make use of the HW acceleration
> framework, but I can't competently advise about it.
>
Hi, can I add a opencl flag to filter context? than the filter just check
the flag and will not ust option, is is OK?
Thanks

> --
> FFmpeg = Fierce and Faithless Mournful Political Extravagant Gorilla
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list