[FFmpeg-devel] [PATCH]Refuse to mux invalid transport streams
Carl Eugen Hoyos
cehoyos at ag.or.at
Mon May 20 17:12:23 CEST 2013
Michael Niedermayer <michaelni <at> gmx.at> writes:
> > > > + av_log(s, AV_LOG_ERROR, "Codec %s not
> > > > supported in transport streams\n",
> > > > + avcodec_get_name(st->codec->codec_id));
> > > > + return AVERROR(EINVAL);
> > >
> > > why dont you set AVOutputFormat.codec_tag
> > It is supposed to be set by the user.
(Sorry, I misunderstood).
Are you sure setting a list of codec_tags is the
right thing to do for the ts muxer?
I always thought it works very different from
how the tags are used by other muxers.
> > > / querry_codec ?
> > I didn't know it and since it has no effect on
> > ffmpeg it wouldn't help;-(
> you could add a call to it into ffmpeg (if that
> doesnt break anything)
>From a quick test, it breaks mkv muxing.
> or just call it from mpegtsenc.c
Isn't that what my current approach does?
(But without the indirection through a
function with an apparently broken API.)
More information about the ffmpeg-devel