[FFmpeg-devel] [PATCH] configure: Enable MinGW-w64's implementation of vsnprintf and pals

Derek Buitenhuis derek.buitenhuis at gmail.com
Thu May 23 19:33:12 CEST 2013


On 2013-05-17 2:14 AM, Reimar Döffinger wrote:
> Isn't that make my point all the stronger and an extra good reason to
> _not_ use two implementations?
> If anything this would be an argument to use a wrapper even on
> Linux/Unix to make sure we do not use %zu by accident, since it's
> not going to work on some systems after all.

We do use %zu, and (certain) people seem dead set against removing its
use, since it is the "most correct" thing to use for size_t prints.

As it stands MSVC and old MinGW are the only platforms which do not have
a proper vsnprintf implementation. Also, our implementation is very
Windows-specific -- it won't work on anything else, and it's silly to
use it anywhere else. Thirdly, the usual "system implementations are
likely more optimzied" argument.

IMHO, the "most correct" thing to do is only provide it for platforms that
need it. You don't see us providing llrint() on platforms that have it, do
you?

- Derek


More information about the ffmpeg-devel mailing list