[FFmpeg-devel] [PATCH] fix crash on AMD K6-3+

Michael Niedermayer michaelni at gmx.at
Sun Nov 3 19:48:39 CET 2013


On Sun, Nov 03, 2013 at 06:00:17PM +0100, Mikulas Patocka wrote:
> Hi
> 
> There are instructions pavgb and pavgusb. Both instructions do the same
> operation but they have different enconding. Pavgb exists in SSE (or
> MMXEXT) instruction set and pavgusb exists in 3D-NOW instruction set.
> 
> livavcodec uses the macro PAVGB to select the proper instruction. However,
> the function avg_pixels8_xy2 doesn't use this macro, it uses pavgb
> directly.
> 
> As a consequence, the function avg_pixels8_xy2 crashes on AMD K6-2 and 
> K6-3 processors, because they have pavgusb, but not pavgb.
> 
> This bug seems to be introduced by commit 
> 71155d7b4157fee44c0d3d0fc1b660ebfb9ccf46, "dsputil: x86: Convert mpeg4 
> qpel and dsputil avg to yasm"
> 
> Signed-off-by: Mikulas Patocka <mikulas at artax.karlin.mff.cuni.cz

patch applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131103/5603332c/attachment.asc>


More information about the ffmpeg-devel mailing list