[FFmpeg-devel] [PATCH] lavu/avstring: add av_get_utf8() function

[Lukasz M]

On 7 November 2013 23:20, Stefano Sabatini <stefasab at gmail.com> wrote:

> On date Thursday 2013-11-07 23:17:13 +0100, Lukasz M encoded:
> > On 7 November 2013 22:03, Stefano Sabatini <stefasab at gmail.com> wrote:
> >
> > > On date Thursday 2013-10-03 01:23:47 +0200, Stefano Sabatini encoded:
> > > > TODO: minor bump, APIchanges entry
> > > > ---
> > > >  libavutil/avstring.c | 25 +++++++++++++++++++++++++
> > > >  libavutil/avstring.h | 10 ++++++++++
> > > >  2 files changed, 35 insertions(+)
> > >
> > > Updated, with utility test included.
> > >
> > > Removed the flags argument since I'm not sure they are really useful.
> > >
> >
> > + * Read an UTF-8 character from buffer in *buf, and update *buf to point
> > to the
> > + * next sequence after the parsed sequence.
> > + * In case of invalid sequence, the point will be updated to the next
> > + * character after the invalid sequence.
> > + *
> > + * @return >= 0 in case a sequence was successfully read, a negative
> > + * value in case of invalid sequence
> > + */
> > +int av_get_utf8(int32_t *code, const uint8_t **buf);
> >
>
> > Feel free to ignore my comment, but function name is a bit misleading. In
> > fact you get a character decoded from utf8 stream. Function name suggests
> > opposite.
>
> av_get_utf8_code()?
> av_get_code_from_utf8()?
> av_decode_utf8()?
>
> I don't mind changing the name of the function.
>

When I poseted I had av_get_code_from_utf8() in mind, but all seems OK.