[FFmpeg-devel] [Bulk] [PATCH] avformat/mov: only force parsing for video tracks if stss is empty

[Michael Niedermayer]

On Wed, Nov 06, 2013 at 10:58:46AM +0100, Hendrik Leppkes wrote:
> On Wed, Nov 6, 2013 at 10:33 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Nov 05, 2013 at 11:13:34AM +0100, Hendrik Leppkes wrote:
> >> On Tue, Nov 5, 2013 at 9:57 AM, Tim Nicholson <nichot20 at yahoo.com> wrote:
> >> > On 04/11/13 15:22, Hendrik Leppkes wrote:
> >> >> Fixes playback of some AAC streams, which are otherwise mangled by the
> >> >> parser, and stss is typically only valid for video anyway.
> >> >
> >> > Typically it only has one entry for video too (which is what I assume
> >> > you mean by valid/empty), *however* just because something is typical,
> >> > is it prudent to asume it will always be the case?
> >> >
> >>
> >> The fact remains that the parser breaks some AAC streams if its
> >> enabled here, and the original issue that this code was supposed to
> >> fix was only related to video, because video needs keyframe
> >> information from the parser if its not available in the container,
> >> while audio does not depend on such metadata.
> >
> > can you share a file that this patch fixes ?
> > might be interresting to look at the aac parser, if it could be fixed
> > to handle it better than ruining the data somehow (which quite
> > independant of this patch seems not optimal behavior)
> >
> 
> Not my file, but made publicly available:
> http://depositfiles.com/files/0hllxnd7z
> (Fair warning, some may consider this file NSFW in very strict environments)
> 
> IIRC, the aac parser is only really designed for parsing ADTS AAC, and
> when it hits raw aac it goes kaboom.

yes, and it isnt trivial to fix that

patch applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131108/70d76323/attachment.asc>