[FFmpeg-devel] [PATCH] build: make sure probed tools don't wait for stdin input.

[Clément Bœsch]

On Sat, Nov 09, 2013 at 12:16:55PM +0100, Michael Niedermayer wrote:
> On Fri, Nov 08, 2013 at 11:56:23PM +0100, Clément Bœsch wrote:
> > On Fri, Nov 08, 2013 at 11:40:34PM +0100, Clément Bœsch wrote:
> > > On Sat, Oct 26, 2013 at 10:45:23PM +0200, Michael Niedermayer wrote:
> > > > On Wed, Jan 09, 2013 at 12:15:46AM +0100, Clément Bœsch wrote:
> > > > > a758c5e added probing for various tools, such as as. Unfortunately, GNU
> > > > > as is reading stdin with -v, and thus configure is stalled with
> > > > > configure arguments such as --as=as.
> > > > > 
> > > > > The --version calls are unchanged because it is supposed to -v + exit.
> > > > > 
> > > > > Fixes Ticket #1898.
> > > > > ---
> > > > >  configure | 24 ++++++++++++------------
> > > > >  1 file changed, 12 insertions(+), 12 deletions(-)
> > > > 
> > > > it seems a few entries where added since this patch, that this patch
> > > > doesnt add "< /dev/null" to
> > > > 
> > > 
> > > > Maybe it would be easier and more robust to check for gnu as at the
> > > > top or so, so it doesnt break when the next entry is added
> > > 
> > > And what would you do in that case? Assume any AS version is supposed to
> > > behave like the GNU AS probing (aka not entering in any of the checks)?
> > > 
> > 
> > Ah... maybe something like attached?
> > 
> > -- 
> > Clément B.
> 
> >  configure |    5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 3f6f0d7f99c2a98febb93dbb572f1d9b33ee7795  0001-build-avoid-stdin-stall-with-GNU-AS-probing.patch
> > From 5b6bc5485629f1e7818b2d6ef78abe0fb050c357 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <u at pkh.me>
> > Date: Fri, 8 Nov 2013 23:55:06 +0100
> > Subject: [PATCH] build: avoid stdin stall with GNU AS probing.
> > 
> > a758c5e added probing for various tools, such as as. Unfortunately, GNU
> > as is reading stdin with -v, and thus configure is stalled with
> > configure arguments such as --as=as.
> > 
> > Fixes Ticket #1898.
> 
> should be ok, also iam happy with any other solution, if you prefer
> another
> 

That last one is simpler so applied.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131109/ea25164b/attachment.asc>